Paths

Table of Contentst

Differential D8684

net: Avoid using C-style NUL-terminated strings in the netbase interface
ClosedPublic
Actions

Authored by PiRK on Dec 17 2020, 12:30.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC4927fc4b11df: net: Avoid using C-style NUL-terminated strings in the netbase interface

Summary

Don't allow resolving of std::string:s with embedded NUL characters.
Avoid using C-style NUL-terminated strings as arguments in the netbase interface
Add tests.

This is a backport of PR17754 [1/3]
https://github.com/bitcoin/bitcoin/pull/17754/commits/9574de86ad703ad942cdd0eca79f48c0d42b102b

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 17 2020, 12:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2020, 12:30

PiRK requested review of this revision.Dec 17 2020, 12:30

teamcity edited the summary of this revision. (Show Details)Dec 17 2020, 12:30

PiRK added a child revision: D8685: net: Add tests for failure on string parameters with embedded NUL characters.Dec 17 2020, 12:34

Harbormaster completed remote builds in B14429: Diff 26399.Dec 17 2020, 12:43

majcosta accepted this revision.Dec 17 2020, 13:23

This revision is now accepted and ready to land.Dec 17 2020, 13:23

Closed by commit rABC4927fc4b11df: net: Avoid using C-style NUL-terminated strings in the netbase interface (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 17 2020, 16:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4927fc4b11df: net: Avoid using C-style NUL-terminated strings in the netbase interface.

Revision Contents
Changeset List

Path

Size

src/

5 lines

8 lines

10 lines

4 lines

16 lines

85 lines

qt/

optionsdialog.cpp

3 lines

rpcconsole.cpp

2 lines

rpc/

net.cpp

4 lines

seeder/

bitcoin.cpp

2 lines

test/

netbase_tests.cpp

2 lines

torcontrol.cpp

2 lines

Diff 26403

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/net.cpp

View Options

src/net_permissions.cpp

View Options

src/netbase.h

View Options

src/netbase.cpp

View Options

src/qt/optionsdialog.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/net.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/test/netbase_tests.cpp

View Options

net: Avoid using C-style NUL-terminated strings in the netbase interfaceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26403

src/httpserver.cpp

src/init.cpp

src/net.cpp

src/net_permissions.cpp

src/netbase.h

src/netbase.cpp

src/qt/optionsdialog.cpp

src/qt/rpcconsole.cpp

src/rpc/net.cpp

src/seeder/bitcoin.cpp

src/test/netbase_tests.cpp

src/torcontrol.cpp

net: Avoid using C-style NUL-terminated strings in the netbase interface
ClosedPublic
Actions

Revision Contents
Changeset List