Paths

Table of Contentst

net: Add tests for failure on string parameters with embedded NUL characters
ClosedPublic
Actions

Authored by PiRK on Dec 17 2020, 12:34.

Details

Reviewers

Fabien
majcosta

Group Reviewers

Restricted Project

Commits

rABCfe17052580c6: net: Add tests for failure on string parameters with embedded NUL characters

Summary

Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters

This is a backport of Core PR17754 [2/3]
https://github.com/bitcoin/bitcoin/pull/17754/commits/fefb9165f23fe9d10ad092ec31715f906e0d2ee7

Depends on D8684

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 17 2020, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2020, 12:34

PiRK requested review of this revision.Dec 17 2020, 12:34

teamcity edited the summary of this revision. (Show Details)Dec 17 2020, 12:34

PiRK added a child revision: D8686: tests: Avoid using C-style NUL-terminated strings as arguments.Dec 17 2020, 12:36

Harbormaster completed remote builds in B14430: Diff 26400.Dec 17 2020, 12:50

Fabien accepted this revision.Dec 17 2020, 13:34

This revision is now accepted and ready to land.Dec 17 2020, 13:34

majcosta accepted this revision.Dec 17 2020, 13:44

Closed by commit rABCfe17052580c6: net: Add tests for failure on string parameters with embedded NUL characters (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 17 2020, 16:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfe17052580c6: net: Add tests for failure on string parameters with embedded NUL characters.

Revision Contents
Changeset List

Path

Size

src/

test/

net_tests.cpp

3 lines

netbase_tests.cpp

24 lines

Diff 26404

View Options

src/test/net_tests.cpp