Differential D8702

rpc: deprecate getaddressinfo label field
ClosedPublic
Actions

Authored by PiRK on Dec 18 2020, 16:53.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC5dadedebd91f: rpc: deprecate getaddressinfo label field

Summary

Note: the help message was already up to date (see D8214)

This is a backport of Core PR17585 [3/5]
https://github.com/bitcoin/bitcoin/pull/17585/commits/d48875fa20d0b71b978cb3d1f85dd9ec14e664cc
Depends on D8701

Test Plan

src/bitcoind &
addr=`src/bitcoin-cli getnewaddress`
src/bitcoin-cli getaddressinfo $addr
src/bitcoin-cli stop

src/bitcoind -deprecatedrpc=label &
src/bitcoin-cli getaddressinfo $addr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 18 2020, 16:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2020, 16:53

PiRK requested review of this revision.Dec 18 2020, 16:53

teamcity edited the summary of this revision. (Show Details)Dec 18 2020, 16:54

PiRK edited the summary of this revision. (Show Details)Dec 18 2020, 16:55

PiRK added a child revision: D8703: test: getaddressinfo label deprecation test.Dec 18 2020, 16:58

Harbormaster completed remote builds in B14450: Diff 26433.Dec 18 2020, 17:07

majcosta accepted this revision.Dec 18 2020, 19:27

This revision is now accepted and ready to land.Dec 18 2020, 19:27

Closed by commit rABC5dadedebd91f: rpc: deprecate getaddressinfo label field (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyDec 19 2020, 11:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5dadedebd91f: rpc: deprecate getaddressinfo label field.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

6 lines

Diff 26447

View Options

rpc: deprecate getaddressinfo label fieldClosedPublicActions