Differential D8716

[net/refactor] Extract m_addr_known logic from initializer list
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:28.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe1e5aca39090: [net/refactor] Extract m_addr_known logic from initializer list

Summary

Partial backport (6/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/af59feb05235ecb85ec9d75b09c66e71268c9889

Depends on D8715.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14467
Build 28898: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28897: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 11:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:28

Fabien requested review of this revision.Dec 21 2020, 11:28

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:29

Fabien added a child revision: D8717: [net/refactor] Add AddrFetch connections to ConnectionType enum.Dec 21 2020, 11:35

Fabien edited the summary of this revision. (Show Details)Dec 21 2020, 11:40

Harbormaster completed remote builds in B14467: Diff 26462.Dec 21 2020, 11:50

PiRK accepted this revision.Dec 21 2020, 13:12

This revision is now accepted and ready to land.Dec 21 2020, 13:12

Closed by commit rABCe1e5aca39090: [net/refactor] Extract m_addr_known logic from initializer list (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe1e5aca39090: [net/refactor] Extract m_addr_known logic from initializer list.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

net.cpp

4 lines

Diff 26462

View Options

src/net.h