Differential D8717

[net/refactor] Add AddrFetch connections to ConnectionType enum
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:35.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe96417b80292: [net/refactor] Add AddrFetch connections to ConnectionType enum

Summary

- AddrFetch connections are short lived connections used to getaddr from
a peer
- previously called "one shot" connections

Partial backport (7/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/442abae2bac7bff85886143df01e14215532b974

Depends on D8716.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14468
Build 28900: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28899: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 11:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:36

Fabien requested review of this revision.Dec 21 2020, 11:36

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:36

Fabien added a child revision: D8718: [doc] Describe different connection types.Dec 21 2020, 11:38

Fabien edited the summary of this revision. (Show Details)Dec 21 2020, 11:41

Harbormaster completed remote builds in B14468: Diff 26463.Dec 21 2020, 12:01

PiRK accepted this revision.Dec 21 2020, 13:14

This revision is now accepted and ready to land.Dec 21 2020, 13:14

Closed by commit rABCe96417b80292: [net/refactor] Add AddrFetch connections to ConnectionType enum (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe96417b80292: [net/refactor] Add AddrFetch connections to ConnectionType enum.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

net.cpp

15 lines

rpc/

net.cpp

5 lines

test/

fuzz/

process_messages.cpp

2 lines

Diff 26463

View Options

src/net.h

View Options

src/net.cpp

View Options

src/rpc/net.cpp

View Options

src/test/fuzz/process_messages.cpp

[net/refactor] Add AddrFetch connections to ConnectionType enumClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26463

src/net.h

src/net.cpp

src/rpc/net.cpp

src/test/fuzz/process_messages.cpp

[net/refactor] Add AddrFetch connections to ConnectionType enum
ClosedPublic
Actions

Revision Contents
Changeset List