Differential D8719

[net/refactor] Add connection type as a member var to CNode
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:44.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC45f9e2cab46f: [net/refactor] Add connection type as a member var to CNode

Summary

- Directly maintaining the connection type prevents having to deduce it
from several flags.

Partial backport (9/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/d3698b5ee309cf0f0cdfb286d6b30a256d7deae5

Depends on D8718.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14470
Build 28904: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28903: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 11:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:44

Fabien requested review of this revision.Dec 21 2020, 11:44

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:44

Fabien added a child revision: D8720: [net/refactor] Remove m_manual_connection flag from CNode.Dec 21 2020, 11:56

Harbormaster completed remote builds in B14470: Diff 26465.Dec 21 2020, 12:12

PiRK accepted this revision.Dec 21 2020, 13:24

This revision is now accepted and ready to land.Dec 21 2020, 13:24

Closed by commit rABC45f9e2cab46f: [net/refactor] Add connection type as a member var to CNode (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC45f9e2cab46f: [net/refactor] Add connection type as a member var to CNode.

Revision Contents
Changeset List

Path

Size

src/

net.h

1 line

net.cpp

2 lines

Diff 26465

View Options

src/net.h