Differential D8724

[net/refactor] Clarify logic for selecting connections in ThreadOpenConnections
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:18.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCa2e090891001: [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections

Summary

Partial backport (14/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/4972c21b671ff73f13a1b5053338b6abbdb471b5

Depends on D8723.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p14

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14475
Build 28914: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28913: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 12:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:18

Fabien requested review of this revision.Dec 21 2020, 12:18

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:18

Fabien added a child revision: D8725: [net] Fix bug where AddrFetch connections would be counted as outbound full relay.Dec 21 2020, 12:23

Harbormaster completed remote builds in B14475: Diff 26470.Dec 21 2020, 12:51

majcosta accepted this revision.Dec 21 2020, 13:50

This revision is now accepted and ready to land.Dec 21 2020, 13:50

Closed by commit rABCa2e090891001: [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa2e090891001: [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections.

Revision Contents
Changeset List

Path

Size

src/

net.cpp

15 lines

Diff 26470

View Options

[net/refactor] Clarify logic for selecting connections in ThreadOpenConnectionsClosedPublicActions