Differential D8729

[net] Remove unnecessary default args on CNode constructor
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 13:04.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7584740e3ff8: [net] Remove unnecessary default args on CNode constructor

Summary

Completes backport (19/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/01e283068b9e6214f2d77a2f772a4244ebfe2274

Depends on D8728.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p19

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14481
Build 28926: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28925: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 13:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 13:04

Fabien requested review of this revision.Dec 21 2020, 13:04

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 13:05

Harbormaster completed remote builds in B14481: Diff 26476.Dec 21 2020, 13:31

majcosta accepted this revision.Dec 21 2020, 14:04

This revision is now accepted and ready to land.Dec 21 2020, 14:04

Fabien added a child revision: D8730: Apply cfilters review fixups.Dec 21 2020, 15:29

Closed by commit rABC7584740e3ff8: [net] Remove unnecessary default args on CNode constructor (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 16:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7584740e3ff8: [net] Remove unnecessary default args on CNode constructor.

Revision Contents
Changeset List

Path

Size

src/

net.h

3 lines

Diff 26476

View Options

[net] Remove unnecessary default args on CNode constructorClosedPublicActions