Page MenuHomePhabricator
Differential D8797

Add link to store and npm components
ClosedPublic
Actions

Authored by bytesofman on Jan 5 2021, 19:39.

Details

Reviewers
Mengerian
Fabien
Group Reviewers
Restricted Project
Commits
rABCWEB5e2dd5220a37: Add link to store and npm components
Summary

Add Chrome Store image linking to Cashtab extension, dev tool links to cashtab-components npm pkg and storybook

Test Plan

Run locally and inspect bcha.html. Confirm active links and tile responsiveness.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
add-ext-and-comps
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14578
Build 29117: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 5 2021, 19:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 19:39
Harbormaster completed remote builds in B14578: Diff 26645.Jan 5 2021, 19:39
bytesofman requested review of this revision.Jan 5 2021, 19:39
Fabien requested changes to this revision.Jan 6 2021, 09:14
Fabien added a subscriber: Fabien.
Fabien added inline comments.
img/chrome-web-store.png
1

Can you add a mention to cashtab somewhere ? It's unclear what is in the store

This revision now requires changes to proceed.Jan 6 2021, 09:14
bytesofman updated this revision to Diff 26680.Jan 6 2021, 12:14

Adding custom Cashtab images

Harbormaster completed remote builds in B14595: Diff 26680.Jan 6 2021, 12:14
Fabien requested changes to this revision.Jan 6 2021, 13:25

New images LGTM

img/chrome-web-store.png
1 ↗(On Diff #26680)

Remove since it's no longer needed

This revision now requires changes to proceed.Jan 6 2021, 13:25
bytesofman updated this revision to Diff 26684.Jan 6 2021, 13:52

Remove unused chrome store image

Harbormaster completed remote builds in B14597: Diff 26684.Jan 6 2021, 13:52
Fabien accepted this revision.Jan 6 2021, 13:58
This revision is now accepted and ready to land.Jan 6 2021, 13:58
Closed by commit rABCWEB5e2dd5220a37: Add link to store and npm components (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 6 2021, 14:09
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABCWEB5e2dd5220a37: Add link to store and npm components.

Revision Contents
Changeset List

PathSize
13 lines
img/

Diff 26645

View Options

bcha.html

Loading...
View Options

img/chrome-web-store.png

Loading...