tests: simplify next_block() function in feature_block
ClosedPublic
Actions

Authored by PiRK on Jan 8 2021, 10:45.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf68b71ad54e0: tests: simplify next_block() function in feature_block

Summary

The solve parameter is unnecessary. Remove it and add
comments.

This is a backport of Core PR18366
Depends on D8846

Test Plan

ninja && test/functional/test_runner.py feature_block

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18350

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14660
Build 29279: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29278: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 8 2021, 10:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2021, 10:45

PiRK requested review of this revision.Jan 8 2021, 10:46

teamcity edited the summary of this revision. (Show Details)Jan 8 2021, 10:46

deadalnix accepted this revision.Jan 8 2021, 11:02

This revision is now accepted and ready to land.Jan 8 2021, 11:02

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: mempool_packages.py ======

------- Stdout: -------
2021-01-08T11:00:51.521000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425
2021-01-08T11:00:58.620000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/mempool_packages.py", line 299, in run_test
    assert tx in mempool1
AssertionError
2021-01-08T11:00:58.670000Z TestFramework (INFO): Stopping nodes
2021-01-08T11:00:58.923000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425
2021-01-08T11:00:58.923000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425/test_framework.log
2021-01-08T11:00:58.923000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: mempool_packages.py

Harbormaster completed remote builds in B14660: Diff 26783.Jan 8 2021, 11:04

This revision was landed with ongoing or failed builds.Jan 8 2021, 18:41

Closed by commit rABCf68b71ad54e0: tests: simplify next_block() function in feature_block (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf68b71ad54e0: tests: simplify next_block() function in feature_block.