Page MenuHomePhabricator

tests: simplify next_block() function in feature_block
ClosedPublic

Authored by PiRK on Fri, Jan 8, 10:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf68b71ad54e0: tests: simplify next_block() function in feature_block
Summary

The solve parameter is unnecessary. Remove it and add
comments.

This is a backport of Core PR18366
Depends on D8846

Test Plan

ninja && test/functional/test_runner.py feature_block

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Fri, Jan 8, 10:46
This revision is now accepted and ready to land.Fri, Jan 8, 11:02

Failed tests logs:

====== Bitcoin ABC functional tests: mempool_packages.py ======

------- Stdout: -------
2021-01-08T11:00:51.521000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425
2021-01-08T11:00:58.620000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/mempool_packages.py", line 299, in run_test
    assert tx in mempool1
AssertionError
2021-01-08T11:00:58.670000Z TestFramework (INFO): Stopping nodes
2021-01-08T11:00:58.923000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425
2021-01-08T11:00:58.923000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425/test_framework.log
2021-01-08T11:00:58.923000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210108_105903/mempool_packages_425' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: mempool_packages.py

This revision was landed with ongoing or failed builds.Fri, Jan 8, 18:41
This revision was automatically updated to reflect the committed changes.