Page MenuHomePhabricator
Differential D8892

RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult
ClosedPublic
Actions

Authored by PiRK on Jan 13 2021, 09:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc077bd1fcf59: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in…
Summary

JSON doesn't allow a trailing comma in Arrays/Objects

This is a backport of Core PR18444

Test Plan

Look at the help message for a command that return a JSON object, and verify that the last item in the output example does not have a trailing comma

src/bitcoin-cli help getblockstats

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 13 2021, 09:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2021, 09:31
PiRK requested review of this revision.Jan 13 2021, 09:31
teamcity edited the summary of this revision. (Show Details)Jan 13 2021, 09:31
Harbormaster completed remote builds in B14730: Diff 26898.Jan 13 2021, 09:45
Fabien requested changes to this revision.Jan 13 2021, 10:58
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/util.cpp
655 ↗(On Diff #26898)

??? did you hit that mouse wheel button unexpectedly ?

This revision now requires changes to proceed.Jan 13 2021, 10:58
PiRK added inline comments.Jan 13 2021, 11:08
src/rpc/util.cpp
655 ↗(On Diff #26898)

Git was completely unable to to locate the changed text and put the conflict in a random place. I must have missed a line when I deleted the conflict

PiRK updated this revision to Diff 26904.Jan 13 2021, 11:22

remove accidental copy past or conflict left-over

Harbormaster completed remote builds in B14736: Diff 26904.Jan 13 2021, 11:34
Fabien accepted this revision.Jan 13 2021, 11:34
This revision is now accepted and ready to land.Jan 13 2021, 11:34
Closed by commit rABCc077bd1fcf59: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in… (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyJan 13 2021, 12:41
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc077bd1fcf59: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in….
PiRK mentioned this in D8900: RPC: Fix more formatting nits.Jan 13 2021, 14:47
PiRK mentioned this in rABC71ac2d99c49f: RPC: Fix more formatting nits.Jan 13 2021, 15:20

Revision Contents
Changeset List

PathSize
src/
rpc/
10 lines

Diff 26909

View Options

src/rpc/util.cpp

Loading...