test: check that peer is connected when calling sync_*
ClosedPublic
Actions

Authored by PiRK on Jan 13 2021, 10:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa05e018b9578: test: check that peer is connected when calling sync_*

Summary

Without a connection there is no way to sync, so we can fail early and don't have to wait for the timeout

This is a backport of Core PR18474

Test Plan

ninja && ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18474

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14735
Build 29428: Build Diff	build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 29427: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 13 2021, 10:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2021, 10:57

PiRK requested review of this revision.Jan 13 2021, 10:57

teamcity edited the summary of this revision. (Show Details)Jan 13 2021, 10:57

Harbormaster completed remote builds in B14735: Diff 26903.Jan 13 2021, 11:08

Fabien accepted this revision.Jan 13 2021, 11:16

This revision is now accepted and ready to land.Jan 13 2021, 11:16

Closed by commit rABCa05e018b9578: test: check that peer is connected when calling sync_* (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 13 2021, 12:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa05e018b9578: test: check that peer is connected when calling sync_*.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

util.py

4 lines

Diff 26903

View Options

test/functional/test_framework/util.py

test: check that peer is connected when calling sync_*ClosedPublicActions