Differential D8908

Fix a -Wunused-variable in the locale fuzzer
ClosedPublic
Actions

Authored by Fabien on Jan 14 2021, 10:00.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf05eb5a011cb: Fix a -Wunused-variable in the locale fuzzer

Summary

This is no longer needed after D8890.
Also turn on -Werror when building the fuzzer to prevent this from
happening again.

Test Plan

ninja bitcoin-fuzzers

Check the warning is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_fuzzer_unused_var

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14758
Build 29472: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29471: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 14 2021, 10:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2021, 10:01

Fabien requested review of this revision.Jan 14 2021, 10:01

Harbormaster completed remote builds in B14758: Diff 26941.Jan 14 2021, 10:18

majcosta accepted this revision.Jan 14 2021, 11:34

This revision is now accepted and ready to land.Jan 14 2021, 11:34

Closed by commit rABCf05eb5a011cb: Fix a -Wunused-variable in the locale fuzzer (authored by Fabien). · Explain WhyJan 14 2021, 13:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf05eb5a011cb: Fix a -Wunused-variable in the locale fuzzer.

Fabien mentioned this in D9004: fuzz: fix unused variable compiler warning.Jan 21 2021, 10:55

Fabien mentioned this in rABCb8d4c2553d0e: fuzz: fix unused variable compiler warning.Jan 21 2021, 14:09

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.yml

1 line

src/

test/

fuzz/

locale.cpp

2 lines

Diff 26941

View Options

contrib/teamcity/build-configurations.yml