Page MenuHomePhabricator

[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD
ClosedPublic

Authored by majcosta on Jan 14 2021, 14:37.

Details

Summary

fa1c8e297 Resolve the qt/guiutil <-> qt/optionsmodal CD (251)

Pull request description:

This pull request attempts to resolve the `qt/guiutil` <-> `qt/optionsmodel` circular dependency.

The `Intro` class in `qt/intro` has a static member function `getDefaultDataDirectory` which is used by `qt/optionsmodel` and creates the circular dependency
`qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/intro -> qt/guiutil`.

This circular dependency is resolved by moving `Intro::getDefaultDataDirectory` to `GUIUtil::getDefaultDataDirectory` without modifying the implementation.

Backport of Core PR15874

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.