HomePhabricator

[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD

Description

[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD

Summary:
fa1c8e297 Resolve the qt/guiutil <-> qt/optionsmodal CD (251)

Pull request description:

This pull request attempts to resolve the `qt/guiutil` <-> `qt/optionsmodel` circular dependency.

The `Intro` class in `qt/intro` has a static member function `getDefaultDataDirectory` which is used by `qt/optionsmodel` and creates the circular dependency
`qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/intro -> qt/guiutil`.

This circular dependency is resolved by moving `Intro::getDefaultDataDirectory` to `GUIUtil::getDefaultDataDirectory` without modifying the implementation.

Backport of Core PR15874

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8916

Details

Provenance
Jonas Schnelli <dev@jonasschnelli.ch>Authored on Apr 23 2019, 16:10
majcostaCommitted on Jan 14 2021, 15:37
majcostaPushed on Jan 14 2021, 15:37
Reviewer
Restricted Project
Differential Revision
D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD
Parents
rABCe811b1ca77f7: Add a test for the banscore deprecation
Branches
Unknown
Tags
Unknown