Page MenuHomePhabricator

Deprecate the `setexcessiveblock` RPC
ClosedPublic

Authored by Fabien on Jan 14 2021, 14:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC953dbd5f2d1b: Deprecate the `setexcessiveblock` RPC
Summary

There already is a configuration option to set the excessive block size.
Removing this RPC fixes several potential bugs:

  • It is potentially racey, as there is no lock on the parameter
  • The CConman object hold its own reference, and will use the wrong value after this RPC is called.
Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.