Paths

Table of Contentst

Differential D8926

Remove useless calls to setexcessiveblock in extended tests
ClosedPublic
Actions

Authored by Fabien on Jan 15 2021, 09:04.

Tags

None

Subscribers

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb6dcf74bae59: Remove useless calls to setexcessiveblock in extended tests

Summary

The excessive block size is already set via the -excessiveblocksize
option, so the calls to the setexcessiveblock RPC is redundant.
This causes the tests to fail since D8918.

Test Plan

./test/functional/test_runner.py \
  abc_p2p_compactblocks \
  abc_p2p_fullblocktest

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_extended_tests_setexcessiveblock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14791
Build 29536: Build Diff	build-diff · build-clang-tidy · build-clang · build-without-wallet · build-debug
Build 29535: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 15 2021, 09:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2021, 09:04

Fabien requested review of this revision.Jan 15 2021, 09:04

@bot build-master

teamcity awarded a token.Jan 15 2021, 09:06

Harbormaster completed remote builds in B14791: Diff 26990.Jan 15 2021, 09:18

s/D8917/D8918/ in the Summary

PiRK accepted this revision.Jan 15 2021, 10:03

This revision is now accepted and ready to land.Jan 15 2021, 10:03

Fabien edited the summary of this revision. (Show Details)Jan 15 2021, 10:09

Closed by commit rABCb6dcf74bae59: Remove useless calls to setexcessiveblock in extended tests (authored by Fabien). · Explain WhyJan 15 2021, 10:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb6dcf74bae59: Remove useless calls to setexcessiveblock in extended tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_compactblocks.py

3 lines

abc_p2p_fullblocktest.py

3 lines

Diff 26990

test/functional/abc_p2p_compactblocks.py

Loading...

test/functional/abc_p2p_fullblocktest.py

Loading...