Differential D8940

[move only] Collect all private members of PeerLogicValidation together
ClosedPublic
Actions

Authored by Fabien on Jan 18 2021, 12:43.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe490dccb870f: [move only] Collect all private members of PeerLogicValidation together

Summary

We don't have a project style for ordering class members, but it always
makes sense to have no more than one of each public/protected/private
specifier.

Also move documentation for MaybeDiscourageAndDisconnect to the header.

Partial backport of core PR19791 (1/9):
https://github.com/bitcoin/bitcoin/pull/19791/commits/824bbd1ffba3df7ffa6f5bfaa31298cd484473b1

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 18 2021, 12:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2021, 12:43

Fabien requested review of this revision.Jan 18 2021, 12:43

teamcity edited the summary of this revision. (Show Details)Jan 18 2021, 12:43

Fabien edited the summary of this revision. (Show Details)Jan 18 2021, 12:50

Harbormaster completed remote builds in B14818: Diff 27034.Jan 18 2021, 12:56

PiRK accepted this revision.Jan 18 2021, 13:00

This revision is now accepted and ready to land.Jan 18 2021, 13:00

Closed by commit rABCe490dccb870f: [move only] Collect all private members of PeerLogicValidation together (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 18 2021, 13:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe490dccb870f: [move only] Collect all private members of PeerLogicValidation together.

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

31 lines

net_processing.cpp

7 lines

Diff 27037

View Options

src/net_processing.h