Page MenuHomePhabricator

[mempool] Persist unbroadcast set to mempool.dat
ClosedPublic

Authored by PiRK on Jan 21 2021, 11:41.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat
Summary

Ensure that the unbroadcast set will still be meaningful if the node is
restarted.

This concludes backport of Core PR18807 [7/7]
https://github.com/bitcoin/bitcoin/pull/18038/commits/50fc4df6c4e8a84bdda13ade7bed7a2131796f00
Depends on D9011

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jan 21 2021, 11:41
majcosta requested changes to this revision.Jan 21 2021, 13:39
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/mempool_persist.py
50 ↗(On Diff #27174)

this isn't added by this PR

194 ↗(On Diff #27174)

comment on its own line

This revision now requires changes to proceed.Jan 21 2021, 13:39

put a comment on its own line

discussed off Phab, the wait_until import should be removed in PR19752

This revision is now accepted and ready to land.Jan 21 2021, 13:53