Differential D9017

script: prevent UB when computing abs value for num opcode serialize
ClosedPublic
Actions

Authored by Fabien on Jan 21 2021, 16:01.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCc05850dc0733: script: prevent UB when computing abs value for num opcode serialize

Summary

Backport of core PR18413.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers
./test/fuzz/test_runner.py <path_to_corpus>

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18413

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14914
Build 29780: Build Diff	lint-circular-dependencies · build-fuzzer · build-diff · build-without-wallet · build-clang · build-clang-tidy · build-debug
Build 29779: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2021, 16:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2021, 16:01

Fabien requested review of this revision.Jan 21 2021, 16:01

teamcity edited the summary of this revision. (Show Details)Jan 21 2021, 16:02

Harbormaster completed remote builds in B14914: Diff 27196.Jan 21 2021, 16:15

deadalnix accepted this revision.Jan 21 2021, 20:52

This revision is now accepted and ready to land.Jan 21 2021, 20:52

Closed by commit rABCc05850dc0733: script: prevent UB when computing abs value for num opcode serialize (authored by pierrenn <git@pnn.sh>, committed by Fabien). · Explain WhyJan 22 2021, 09:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc05850dc0733: script: prevent UB when computing abs value for num opcode serialize.

Revision Contents
Changeset List

Path

Size

src/

script/

script.h

3 lines

test/

fuzz/

integer.cpp

8 lines

scriptnum_ops.cpp

8 lines

Diff 27196

View Options

src/script/script.h

View Options

src/test/fuzz/integer.cpp

View Options

src/test/fuzz/scriptnum_ops.cpp

script: prevent UB when computing abs value for num opcode serializeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27196

src/script/script.h

src/test/fuzz/integer.cpp

src/test/fuzz/scriptnum_ops.cpp

script: prevent UB when computing abs value for num opcode serialize
ClosedPublic
Actions

Revision Contents
Changeset List