test: add factor option to adjust test timeouts
ClosedPublic
Actions

Authored by PiRK on Jan 22 2021, 08:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6f4e54072a42: test: add factor option to adjust test timeouts

Summary

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
This PR adds a new option factor that can be used to adjust timeouts in various functional tests.
Several timeouts and functions from authproxy, mininode, test_node and util have been adapted to use this option. The factor-option definition is located in test_framework.py.
Fixes #18266
Also Fixes #18834

This is a backport of Core PR18617

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 22 2021, 08:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2021, 08:22

PiRK requested review of this revision.Jan 22 2021, 08:22

teamcity edited the summary of this revision. (Show Details)Jan 22 2021, 08:22

PiRK mentioned this in D9023: wallet] remove nLastResend logic.Jan 22 2021, 08:31

PiRK mentioned this in D9024: [rpc] add unbroadcast info to mempool entries and getmempoolinfo.

PiRK mentioned this in D9025: [mempool] sanity check that all unbroadcast txns are in mempool.Jan 22 2021, 08:33

Harbormaster completed remote builds in B14932: Diff 27223.Jan 22 2021, 08:33

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: mempool_unbroadcast.py ======

------- Stdout: -------
2021-01-22T08:32:52.830000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210122_082956/mempool_unbroadcast_459
2021-01-22T08:32:53.271000Z TestFramework (INFO): Test that mempool reattempts delivery of locally submitted transaction
2021-01-22T08:32:53.573000Z TestFramework (INFO): Generate transactions that only node 0 knows about
2021-01-22T08:32:53.645000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 122, in main
    self.run_test()
  File "/work/test/functional/mempool_unbroadcast.py", line 28, in run_test
    self.test_broadcast()
  File "/work/test/functional/mempool_unbroadcast.py", line 55, in test_broadcast
    rpc_tx_hsh = node.sendrawtransaction(txFS["hex"])
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: txn-mempool-conflict (-26)
2021-01-22T08:32:53.698000Z TestFramework (INFO): Stopping nodes
2021-01-22T08:32:54.006000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210122_082956/mempool_unbroadcast_459
2021-01-22T08:32:54.006000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210122_082956/mempool_unbroadcast_459/test_framework.log
2021-01-22T08:32:54.007000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210122_082956/mempool_unbroadcast_459' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: mempool_unbroadcast.py

PiRK added a child revision: D9023: wallet] remove nLastResend logic.Jan 22 2021, 08:33

Fabien requested changes to this revision.Jan 22 2021, 08:57

Fabien added a subscriber: Fabien.

Fabien added inline comments.