test: Add mempool_updatefromblock.py
ClosedPublic
Actions

Authored by PiRK on Jan 22 2021, 15:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4a29fe3f7a60: test: Add mempool_updatefromblock.py

Summary

This PR adds a new test for mempool update of transaction descendants/ancestors information (count, size) when transactions have been re-added from a disconnected block to the mempool.

This is a backport of Core PR18485

Note: on line 110, 'vsize' had to be replaced by 'size' to make the test work for ABC

Test Plan

test/functional/test_runner.py mempool_upd*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18485

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14974
Build 29900: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29899: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 22 2021, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2021, 15:29

PiRK requested review of this revision.Jan 22 2021, 15:29

teamcity edited the summary of this revision. (Show Details)Jan 22 2021, 15:30

Harbormaster completed remote builds in B14956: Diff 27267.Jan 22 2021, 15:45

Please check the PR #

This revision now requires changes to proceed.Jan 22 2021, 15:51

correct PR number

Fabien requested changes to this revision.Jan 22 2021, 19:21

Fabien added inline comments.

test/functional/mempool_updatefromblock.py
86 ↗	(On Diff #27267)	TIL quantize
152 ↗	(On Diff #27267)	This is actually 50, would make sense to increase the batch size accordingly

This revision now requires changes to proceed.Jan 22 2021, 19:21

adjust the batch size from 25 to 50, to account for ABC's DEFAULT_ANCESTOR_LIMIT.

This requires raising -limitdescendantsize and -limitancestorsize= to 5000, to avoid hitting an error.
And it increases the test duration from 66 s to 266 seconds on my workstation.

Harbormaster completed remote builds in B14974: Diff 27294.Jan 25 2021, 15:25

Fabien accepted this revision.Jan 25 2021, 16:38

This revision is now accepted and ready to land.Jan 25 2021, 16:38

Closed by commit rABC4a29fe3f7a60: test: Add mempool_updatefromblock.py (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJan 25 2021, 17:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4a29fe3f7a60: test: Add mempool_updatefromblock.py.

PiRK mentioned this in D9831: net: Remove forcerelay of rejected txs.Jul 22 2021, 14:33

PiRK mentioned this in rABC1ee3e4bda416: net: Remove forcerelay of rejected txs.Aug 30 2021, 08:38