Page MenuHomePhabricator
Differential D9049

[net processing] Move Misbehaving() to PeerManager
ClosedPublic
Actions

Authored by Fabien on Jan 25 2021, 10:05.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC245041dc2324: [net processing] Move Misbehaving() to PeerManager
Summary

Completes backport (9/9) of core PR19791:
https://github.com/bitcoin/bitcoin/pull/19791/commits/bb6a32ce9983c72afa90f41a43a47ffd703ca006

Depends on D9048.

Also moves the other Misbehaving() prototype (specific to our
codebase) as a private method.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2021, 10:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2021, 10:05
Fabien requested review of this revision.Jan 25 2021, 10:05
Harbormaster completed remote builds in B14969: Diff 27289.Jan 25 2021, 10:05
teamcity edited the summary of this revision. (Show Details)Jan 25 2021, 10:05
majcosta requested changes to this revision.Jan 25 2021, 15:48
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/test/denialofservice_tests.cpp
258 ↗(On Diff #27289)

comment on its own line

This revision now requires changes to proceed.Jan 25 2021, 15:48
Fabien updated this revision to Diff 27300.Jan 25 2021, 16:36

Fix comment

Harbormaster completed remote builds in B14979: Diff 27300.Jan 25 2021, 16:52
teamcity added a comment.Jan 25 2021, 16:52
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

wallet_create_tx.py                              | ✓ Passed  | 7 s
wallet_createwallet.py                           | ✓ Passed  | 2 s
wallet_createwallet.py --usecli                  | ✓ Passed  | 3 s
wallet_descriptor.py                             | ✓ Passed  | 8 s
wallet_disable.py                                | ✓ Passed  | 1 s
wallet_dump.py                                   | ✓ Passed  | 5 s
wallet_encryption.py                             | ✓ Passed  | 5 s
wallet_hd.py                                     | ✓ Passed  | 5 s
wallet_import_rescan.py                          | ✓ Passed  | 9 s
wallet_import_with_label.py                      | ✓ Passed  | 1 s
wallet_importdescriptors.py                      | ✓ Passed  | 5 s
wallet_importmulti.py                            | ✓ Passed  | 5 s
wallet_importprunedfunds.py                      | ✓ Passed  | 1 s
wallet_keypool.py                                | ✓ Passed  | 3 s
wallet_keypool_topup.py                          | ✓ Passed  | 3 s
wallet_labels.py                                 | ✓ Passed  | 2 s
wallet_listreceivedby.py                         | ✓ Passed  | 16 s
wallet_listsinceblock.py                         | ✓ Passed  | 6 s
wallet_listtransactions.py                       | ✓ Passed  | 14 s
wallet_multiwallet.py                            | ✓ Passed  | 11 s
wallet_multiwallet.py --usecli                   | ✓ Passed  | 13 s
wallet_reorgsrestore.py                          | ✓ Passed  | 4 s
wallet_resendwallettransactions.py               | ✓ Passed  | 6 s
wallet_txn_clone.py                              | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock                  | ✓ Passed  | 3 s
wallet_txn_doublespend.py                        | ✓ Passed  | 2 s
wallet_txn_doublespend.py --mineblock            | ✓ Passed  | 3 s
wallet_watchonly.py                              | ✓ Passed  | 1 s
wallet_watchonly.py --usecli                     | ✓ Passed  | 1 s
wallet_zapwallettxes.py                          | ✓ Passed  | 4 s

ALL                                              | ✓ Passed  | 1079 s (accumulated) 
Runtime: 221 s

[164/438] avalanche: testing processor_tests
FAILED: src/avalanche/test/CMakeFiles/check-avalanche-processor_tests 
cd /work/abc-ci-builds/build-debug/src/avalanche/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/avalanche-processor_tests.log /work/abc-ci-builds/build-debug/src/avalanche/test/test-avalanche --run_test=processor_tests --logger=HRF,message:JUNIT,message,avalanche-processor_tests.xml --catch_system_errors=no
Segmentation fault (core dumped)
[176/438] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[177/438] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[188/438] Running seeder test suite
PASSED: seeder test suite
[410/438] Running pow test suite
PASSED: pow test suite
[430/438] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[435/438] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
majcosta added a comment.Jan 25 2021, 18:16

@bot build-debug

teamcity awarded a token.Jan 25 2021, 18:17
majcosta accepted this revision.Jan 25 2021, 18:49
This revision is now accepted and ready to land.Jan 25 2021, 18:49
Closed by commit rABC245041dc2324: [net processing] Move Misbehaving() to PeerManager (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 26 2021, 07:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC245041dc2324: [net processing] Move Misbehaving() to PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
17 lines
test/
4 lines
4 lines
22 lines
15 lines
test/
11 lines

Diff 27312

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...