Paths

Table of Contentst

Differential D9091

[Web - New] Adding cashtab-components source
ClosedPublic
Actions

Authored by bytesofman on Jan 27 2021, 21:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6705b69d8931: [Web - New] Adding cashtab-components source

Summary

Adds source code of published npm package, cashtab-components. Codebase currently available at https://github.com/josephroyking/cashtab-components. NPM module here: https://www.npmjs.com/package/cashtab-components. This was refactored from https://github.com/Bitcoin-com/badger-components-react , adding typescript, upgrading React, and upgrading Storybook. Starting point here because TypeScript refactor of original source code proved more involved than foreseen, more an overhaul than a diff.

Test Plan

cd web/cashtab-components
npm ci
npm run storybook

Component library will load at localhost:6006 (should open automatically in browser)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-cashtab-components

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15067
Build 30084: Build Diff
Build 30083: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 27 2021, 21:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 21:01

bytesofman requested review of this revision.Jan 27 2021, 21:01

Harbormaster completed remote builds in B15025: Diff 27376.Jan 27 2021, 21:01

I recommend using npm ci instead of npm i --legacy-peer-deps, since that'll give you a deterministic build according to the existing package-lock.json which is in the diff already

also, yarn.lock should be deleted, I think?

This revision now requires changes to proceed.Jan 28 2021, 20:27

bytesofman edited the test plan for this revision. (Show Details)Jan 29 2021, 13:46

Delete yarn.lock (bitcoin-abc repo uses npm, not yarn)

Harbormaster completed remote builds in B15053: Diff 27428.Jan 29 2021, 13:48

majcosta requested changes to this revision.Jan 29 2021, 19:24

majcosta added inline comments.

web/cashtab-components/.gitignore
19 ↗	(On Diff #27428)	this probably goes in macOS users $HOME/.gitignore file rather than the repo
26–27 ↗	(On Diff #27428)	remove
web/cashtab-components/README.md
3 ↗	(On Diff #27428)	https://chrome.google.com/webstore/detail/cashtab/obldfcmebhllhjlhjbnghaipekcppeag
25 ↗	(On Diff #27428)	https://chrome.google.com/webstore/detail/cashtab/obldfcmebhllhjlhjbnghaipekcppeag

This revision now requires changes to proceed.Jan 29 2021, 19:24

README patch, .gitignore remove yarn

Harbormaster completed remote builds in B15067: Diff 27452.Feb 1 2021, 14:27

LGTM

This revision is now accepted and ready to land.Feb 1 2021, 18:14

Closed by commit rABC6705b69d8931: [Web - New] Adding cashtab-components source (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyFeb 1 2021, 19:25

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC6705b69d8931: [Web - New] Adding cashtab-components source.

Revision Contents
Changeset List

Path

Size

web/

cashtab-components/

1 line

25 lines

.storybook/

cashtabTheme.js

9 lines

11 lines

6 lines

3 lines

13 lines

206 lines

package-lock.json

50503 lines

93 lines

public/

cashtab-components.png

42 lines

25 lines

3 lines

src/

@types/

assets/

21 lines

atoms/

Button/

Button.stories.tsx

58 lines

151 lines

12 lines

3 lines

ButtonQR/

ButtonQR.stories.tsx

86 lines

203 lines

14 lines

3 lines

11 lines

14 lines

9 lines

Ticker/

24 lines

3 lines

4 lines

components/

CashtabBadge/

CashtabBadge.stories.tsx

109 lines

CashtabBadge.tsx

190 lines

47 lines

3 lines

CashtabButton/

CashtabButton.stories.tsx

109 lines

CashtabButton.tsx

137 lines

41 lines

3 lines

PriceDisplay/

PriceDisplay.stories.tsx

75 lines

PriceDisplay.tsx

84 lines

7 lines

3 lines

3 lines

hoc/

CashtabBase/

CashtabBase.tsx

424 lines

26 lines

11 lines

1 line

images/

12-bitcoin-cash-square-crop.svg

1 line

23 lines

19 lines

bitcoin-cash-logo.svg

1 line

bitcoin-cash.svg

1 line

simple-ledger-protocol-logo.png

5 lines

react-app-env.d.ts

1 line

styles/

15 lines

utils/

cashtab-helpers.ts

124 lines

currency-helpers.ts

526 lines

2 lines

23 lines

webpack.config.js

79 lines

Diff 27452

web/cashtab-components/.eslintignore

Loading...

web/cashtab-components/.gitignore

Loading...

web/cashtab-components/.storybook/cashtabTheme.js

Loading...

web/cashtab-components/.storybook/main.js

Loading...

web/cashtab-components/.storybook/manager.js

Loading...

web/cashtab-components/.storybook/preview.js

Loading...

web/cashtab-components/CHANGELOG.md

Loading...

web/cashtab-components/README.md

Loading...

web/cashtab-components/package-lock.json

Loading...

web/cashtab-components/package.json

Loading...

web/cashtab-components/public/cashtab-components.png

Loading...

web/cashtab-components/public/favicon.ico

Loading...

web/cashtab-components/public/index.html

Loading...

web/cashtab-components/public/logo192.png

Loading...

web/cashtab-components/public/logo512.png

Loading...

web/cashtab-components/public/manifest.json

Loading...

web/cashtab-components/public/robots.txt

Loading...

web/cashtab-components/src/@types/assets/index.d.ts

Loading...

web/cashtab-components/src/atoms/Button/Button.stories.tsx

Loading...

web/cashtab-components/src/atoms/Button/Button.tsx

Loading...

web/cashtab-components/src/atoms/Button/README.md

Loading...

web/cashtab-components/src/atoms/Button/index.ts

Loading...

web/cashtab-components/src/atoms/ButtonQR/ButtonQR.stories.tsx

Loading...

web/cashtab-components/src/atoms/ButtonQR/ButtonQR.tsx

Loading...

web/cashtab-components/src/atoms/ButtonQR/README.md

Loading...

web/cashtab-components/src/atoms/ButtonQR/index.ts

Loading...

web/cashtab-components/src/atoms/H3.ts

Loading...

web/cashtab-components/src/atoms/Small.ts

Loading...

web/cashtab-components/src/atoms/Text.ts

Loading...

web/cashtab-components/src/atoms/Ticker/Ticker.tsx

Loading...

web/cashtab-components/src/atoms/Ticker/index.ts

Loading...

web/cashtab-components/src/atoms/index.ts

Loading...

web/cashtab-components/src/components/CashtabBadge/CashtabBadge.stories.tsx

Loading...

web/cashtab-components/src/components/CashtabBadge/CashtabBadge.tsx

Loading...

web/cashtab-components/src/components/CashtabBadge/README.md

Loading...

web/cashtab-components/src/components/CashtabBadge/index.ts

Loading...

web/cashtab-components/src/components/CashtabButton/CashtabButton.stories.tsx

Loading...

web/cashtab-components/src/components/CashtabButton/CashtabButton.tsx

Loading...

web/cashtab-components/src/components/CashtabButton/README.md

Loading...

web/cashtab-components/src/components/CashtabButton/index.ts

Loading...

web/cashtab-components/src/components/PriceDisplay/PriceDisplay.stories.tsx

Loading...

web/cashtab-components/src/components/PriceDisplay/PriceDisplay.tsx

Loading...

web/cashtab-components/src/components/PriceDisplay/README.md

Loading...

web/cashtab-components/src/components/PriceDisplay/index.ts

Loading...

web/cashtab-components/src/components/index.ts

Loading...

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx

Loading...

web/cashtab-components/src/hoc/CashtabBase/README.md

Loading...

web/cashtab-components/src/hoc/CashtabBase/index.ts

Loading...

web/cashtab-components/src/hoc/index.ts

Loading...

web/cashtab-components/src/images/12-bitcoin-cash-square-crop.svg

Loading...

web/cashtab-components/src/images/CheckSVG.tsx

Loading...

web/cashtab-components/src/images/LoadSVG.tsx

Loading...

web/cashtab-components/src/images/bitcoin-cash-logo.svg

Loading...

web/cashtab-components/src/images/bitcoin-cash.svg

Loading...

web/cashtab-components/src/images/simple-ledger-protocol-logo.png

Loading...

web/cashtab-components/src/images/slp-logo.png

Loading...

web/cashtab-components/src/index.ts

Loading...

web/cashtab-components/src/react-app-env.d.ts

Loading...

web/cashtab-components/src/styles/colors.js

Loading...

web/cashtab-components/src/utils/cashtab-helpers.ts

Loading...

web/cashtab-components/src/utils/currency-helpers.ts

Loading...

web/cashtab-components/src/utils/index.ts

Loading...

web/cashtab-components/tsconfig.json

Loading...

web/cashtab-components/webpack.config.js

Loading...