Paths

Table of Contentst

Differential D9107

remove NETWORK_NAME
ClosedPublic
Actions

Authored by PiRK on Jan 28 2021, 15:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5ee8dcba43aa: remove NETWORK_NAME

Summary

This is no longer relevant, now that we support only a single network.

Test Plan

ninja && src/bitcoind -h | grep version

Check the version number also in src/qt/bitcoin-qt Menu Help -> About Bitcoin ABC

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 28 2021, 15:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2021, 15:37

PiRK requested review of this revision.Jan 28 2021, 15:37

Harbormaster completed remote builds in B15047: Diff 27414.Jan 28 2021, 15:53

Fabien accepted this revision.Jan 28 2021, 16:39

This revision is now accepted and ready to land.Jan 28 2021, 16:39

Closed by commit rABC5ee8dcba43aa: remove NETWORK_NAME (authored by PiRK). · Explain WhyJan 28 2021, 16:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5ee8dcba43aa: remove NETWORK_NAME.

PiRK mentioned this in D11563: remove unneeded includes of core_io.h and network.h.Jun 3 2022, 10:43

PiRK mentioned this in rABCc747d3f9db61: remove unneeded includes of core_io.h and network.h.Jun 7 2022, 08:25

Revision Contents
Changeset List

Path

Size

src/

bitcoind.cpp

4 lines

network.h

1 line

networks/

abc/

network.cpp

1 line

qt/

utilitydialog.cpp

3 lines

Diff 27419

View Options

src/bitcoind.cpp

View Options

src/network.h

View Options

src/networks/abc/network.cpp

View Options

remove NETWORK_NAMEClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27419

src/bitcoind.cpp

src/network.h

src/networks/abc/network.cpp

src/qt/utilitydialog.cpp

remove NETWORK_NAME
ClosedPublic
Actions

Revision Contents
Changeset List