Page MenuHomePhabricator
Differential D910

[Wallet] refactor CWallet/CWalletDB/CDB
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2018, 00:09.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9c418623a5a1: [Wallet] refactor CWallet/CWalletDB/CDB
rABC9c418623a5a1: [Wallet] refactor CWallet/CWalletDB/CDB
Summary

Try to hide CDB/bitdb behinde CWalletDB.
Prepare for full wallet database abstraction.

Backport of core's PR8574

Depends on D908

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletdbrefac
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/wallet/wallet.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 1540
Build 1540: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 7 2018, 00:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2018, 00:09
deadalnix updated this revision to Diff 2390.Jan 7 2018, 00:14

Fix typos

Harbormaster completed remote builds in B1541: Diff 2390.Jan 7 2018, 00:14
schancel accepted this revision.Jan 10 2018, 01:32
schancel added inline comments.
src/wallet/db.cpp
661 ↗(On Diff #2390)

IMO this if should be inverted with a return false;

This revision is now accepted and ready to land.Jan 10 2018, 01:32
Closed by commit rABC9c418623a5a1: [Wallet] refactor CWallet/CWalletDB/CDB (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by deadalnix). · Explain WhyJan 10 2018, 01:49
This revision was automatically updated to reflect the committed changes.
deadalnix added a child revision: D928: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB.Jan 10 2018, 20:19

Revision Contents
Changeset List

PathSize
src/
wallet/
21 lines
168 lines
69 lines
28 lines
146 lines

Diff 2389

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...