Page MenuHomePhabricator
Differential D928

Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
ClosedPublic
Actions

Authored by deadalnix on Jan 10 2018, 20:19.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGe4b96385f761: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
rABCe4b96385f761: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
Summary

Backport core's PR9605

Depends on D910

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 10 2018, 20:19
Harbormaster completed remote builds in B1567: Diff 2437.Jan 10 2018, 20:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2018, 20:19
Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix added a child revision: D927: Use internal HD wallet for change outputs.Jan 10 2018, 20:19
schancel accepted this revision.Jan 10 2018, 20:36
schancel added inline comments.
src/net.cpp
2473 ↗(On Diff #2437)

The rest of this code still uses boost::bind

src/scheduler.cpp
121 ↗(On Diff #2437)

This is just to work with `boost::bind`?

src/wallet/walletdb.cpp
792 ↗(On Diff #2437)

If something in here throws and exception, this is never going to get reset properly. :(

This revision is now accepted and ready to land.Jan 10 2018, 20:36
deadalnix added inline comments.Jan 10 2018, 20:44
src/scheduler.cpp
121 ↗(On Diff #2437)

I guess so :) This is what the code does. We want to move everything toward std::bind but this is kind of out of the scope of this backport.

src/wallet/walletdb.cpp
792 ↗(On Diff #2437)

Absolutely true. That would deserve a task.

deadalnix mentioned this in T159: MaybeCompactWalletDB use a bunch of static variable and is not exception safe.Jan 10 2018, 20:57
Closed by commit rABCe4b96385f761: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJan 10 2018, 21:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
16 lines
16 lines
wallet/
5 lines
9 lines
4 lines
39 lines

Diff 2441

View Options

src/init.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/scheduler.h

Loading...
View Options

src/scheduler.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...