Page MenuHomePhabricator

Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
ClosedPublic

Authored by deadalnix on Jan 10 2018, 20:19.

Details

Summary

Backport core's PR9605

Depends on D910

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
threadflushwalletdb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1567
Build 1567: arc lint + arc unit

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald Transcript
schancel added inline comments.
src/net.cpp
2473

The rest of this code still uses boost::bind

src/scheduler.cpp
121

This is just to work with `boost::bind`?

src/wallet/walletdb.cpp
792

If something in here throws and exception, this is never going to get reset properly. :(

This revision is now accepted and ready to land.Jan 10 2018, 20:36
src/scheduler.cpp
121

I guess so :) This is what the code does. We want to move everything toward std::bind but this is kind of out of the scope of this backport.

src/wallet/walletdb.cpp
792

Absolutely true. That would deserve a task.

This revision was automatically updated to reflect the committed changes.