Remove virtual from function marked override already.
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2018, 20:08.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING38fcafed8ec9: Remove virtual from function marked override already.
rABC38fcafed8ec9: Remove virtual from function marked override already.

Summary

This is redundant.

Test Plan

make check.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

virtualoverride

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1548
Build 1548: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 7 2018, 20:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2018, 20:08

Harbormaster completed remote builds in B1548: Diff 2403.Jan 7 2018, 20:08

deadalnix mentioned this in D913: CValidationInterface cleanups.Jan 7 2018, 20:10

deadalnix added a child revision: D913: CValidationInterface cleanups.Jan 7 2018, 20:11

schancel accepted this revision.Jan 8 2018, 00:48

This revision is now accepted and ready to land.Jan 8 2018, 00:48

Closed by commit rABC38fcafed8ec9: Remove virtual from function marked override already. (authored by deadalnix). · Explain WhyJan 8 2018, 00:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

20 lines

rpc/

mining.cpp

4 lines

Diff 2403

View Options

src/net_processing.h