Page MenuHomePhabricator

[Cashtab] Add missing meta field per errors reported by Twitter card validator
ClosedPublic

Authored by josephroyking on Wed, Feb 10, 19:19.

Details

Summary

Twitter card validator throws errors indicating the og:title field is required; adding it

Test Plan

npm test to confirm app is not affected, will need to test after deployment to confirm Twitter appearance

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested changes to this revision.Wed, Feb 10, 19:25
majcosta added a subscriber: majcosta.
majcosta added inline comments.
web/cashtab/public/index.html
33–34 ↗(On Diff #27646)

are these supposed to be removed too?

This revision now requires changes to proceed.Wed, Feb 10, 19:25

Removed as they were not present in the card generated for docs.cashtabapp.com, which now works. So, they are either causing an error or unnecessary.

This revision is now accepted and ready to land.Wed, Feb 10, 20:16