Page MenuHomePhabricator
Differential D9207

[Cashtab] Add missing meta field per errors reported by Twitter card validator
ClosedPublic
Actions

Authored by bytesofman on Feb 10 2021, 19:19.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC7999e45bd7a9: [Cashtab] Add missing meta field per errors reported by Twitter card validator
Summary

Twitter card validator throws errors indicating the og:title field is required; adding it

Test Plan

npm test to confirm app is not affected, will need to test after deployment to confirm Twitter appearance

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-twitter-card-cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15175
Build 30296: Build Diffcashtab-tests
Build 30295: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 10 2021, 19:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2021, 19:20
bytesofman requested review of this revision.Feb 10 2021, 19:20
majcosta requested changes to this revision.Feb 10 2021, 19:25
majcosta added a subscriber: majcosta.
majcosta added inline comments.
web/cashtab/public/index.html
33–34

are these supposed to be removed too?

This revision now requires changes to proceed.Feb 10 2021, 19:25
bytesofman requested review of this revision.Feb 10 2021, 19:33

Removed as they were not present in the card generated for docs.cashtabapp.com, which now works. So, they are either causing an error or unnecessary.

Harbormaster completed remote builds in B15175: Diff 27646.Feb 10 2021, 20:00
majcosta accepted this revision.Feb 10 2021, 20:16
This revision is now accepted and ready to land.Feb 10 2021, 20:16
Closed by commit rABC7999e45bd7a9: [Cashtab] Add missing meta field per errors reported by Twitter card validator (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyFeb 10 2021, 20:19
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABC7999e45bd7a9: [Cashtab] Add missing meta field per errors reported by Twitter card validator.

Revision Contents
Changeset List

PathSize
web/
cashtab/
public/
5 lines

Diff 27646

View Options

web/cashtab/public/index.html

Loading...