Page MenuHomePhabricator
Differential D9240

cli: use GetWalletBalances() functionality for -getinfo
ClosedPublic
Actions

Authored by PiRK on Feb 17 2021, 14:42.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC984a96569bcf: cli: use GetWalletBalances() functionality for -getinfo
Summary

and replace GetBoolArg with IsArgSet as we only want
to know if the arg is passed; we do not need the value.

This is a backport of Core PR18594 [4/6]
https://github.com/bitcoin/bitcoin/pull/18594/commits/afce85eb994384246e455b766549c3206cb059e0

Depends on D9239

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 17 2021, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2021, 14:42
PiRK requested review of this revision.Feb 17 2021, 14:42
teamcity edited the summary of this revision. (Show Details)Feb 17 2021, 14:43
PiRK added a child revision: D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.Feb 17 2021, 14:43
Harbormaster completed remote builds in B15218: Diff 27721.Feb 17 2021, 15:01
majcosta accepted this revision.Feb 17 2021, 19:14
This revision is now accepted and ready to land.Feb 17 2021, 19:14
PiRK updated this revision to Diff 27734.Feb 18 2021, 07:47

remove maybe_unused annotation

Harbormaster completed remote builds in B15229: Diff 27734.Feb 18 2021, 08:20
Closed by commit rABC984a96569bcf: cli: use GetWalletBalances() functionality for -getinfo (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 18 2021, 13:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC984a96569bcf: cli: use GetWalletBalances() functionality for -getinfo.
PiRK mentioned this in D9951: remove [[mabye_unused]] annotation for GetWalletBalances.Aug 25 2021, 16:30
PiRK mentioned this in rABCd219a72883f6: remove [[mabye_unused]] annotation for GetWalletBalances.Aug 26 2021, 08:08

Revision Contents
Changeset List

PathSize
src/
7 lines

Diff 27744

View Options

src/bitcoin-cli.cpp

Loading...