Paths

Table of Contentst

Differential D9289

[Cashtab] Error handling for formatBalance
ClosedPublic
Actions

Authored by bytesofman on Mar 2 2021, 13:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0abbfac420be: [Cashtab] Error handling for formatBalance

Summary

Return '0' in formatBalance if input cannot be processed. Add unit tests for 0, null, and undefined inputs.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 2 2021, 13:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2021, 13:17

bytesofman requested review of this revision.Mar 2 2021, 13:17

Harbormaster completed remote builds in B15296: Diff 27851.Mar 2 2021, 13:23

Return x instead of '0' in catch loop

Fabien accepted this revision.Mar 2 2021, 13:31

This revision is now accepted and ready to land.Mar 2 2021, 13:31

Harbormaster completed remote builds in B15297: Diff 27852.Mar 2 2021, 13:32

Closed by commit rABC0abbfac420be: [Cashtab] Error handling for formatBalance (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyMar 2 2021, 13:35

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC0abbfac420be: [Cashtab] Error handling for formatBalance.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__tests__/

cashMethods.test.js

9 lines

cashMethods.js

15 lines

Diff 27853

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Error handling for formatBalanceClosedPublicActions