Page MenuHomePhabricator
Differential D9319

assumptions: Assume C++17
ClosedPublic
Actions

Authored by Fabien on Mar 11 2021, 15:38.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1c56263f7af1: assumptions: Assume C++17
Summary

Backport of core#21274.
The __cplusplus expected value has already been updated, so only
update the comments and remove the #ifdef.

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 11 2021, 15:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2021, 15:38
Fabien requested review of this revision.Mar 11 2021, 15:38
PiRK accepted this revision.Mar 11 2021, 15:58
PiRK added a subscriber: PiRK.

In the summary, change PR21274 -> core#21274.

I think the backport flagging bot sstill needs to be updated to take this new convention into account.

This revision is now accepted and ready to land.Mar 11 2021, 15:58
Harbormaster completed remote builds in B15347: Diff 27927.Mar 11 2021, 15:58
Fabien edited the summary of this revision. (Show Details)Mar 11 2021, 16:02
Closed by commit rABC1c56263f7af1: assumptions: Assume C++17 (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyMar 11 2021, 16:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1c56263f7af1: assumptions: Assume C++17.

Revision Contents
Changeset List

PathSize
src/
compat/
10 lines

Diff 27931

View Options

src/compat/assumptions.h

Loading...