Page MenuHomePhabricator
Differential D9329

[avalanche] implement buildRemoteSighash and buildLocalSighash
ClosedPublic
Actions

Authored by PiRK on Mar 18 2021, 09:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf07ea60dfe3a: [avalanche] implement buildRemoteSighash and buildLocalSighash
Summary

buildLocalSighash is extracted from sendHello and buildRemoteSighash will be used in D9327 to check the AVAHELLO message sent by a peer.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 18 2021, 09:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2021, 09:19
PiRK requested review of this revision.Mar 18 2021, 09:19
PiRK mentioned this in D9327: [avalanche] implement an avalanche handshake.Mar 18 2021, 09:24
PiRK added a child revision: D9327: [avalanche] implement an avalanche handshake.Mar 18 2021, 09:24
Harbormaster completed remote builds in B15366: Diff 27955.Mar 18 2021, 09:33
PiRK added a comment.Mar 18 2021, 09:48

I just noticed that buildRemoteChallenge is already implemented in the test framework and is called get_sighash: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/test_framework/messages.py$998

Maybe getSigHash is a more descriptive name?

PiRK updated this revision to Diff 27968.Mar 19 2021, 13:16

rename "Challenge" -> "Sighash" to keep the c++ and python code consistent

PiRK retitled this revision from [avalanche] implement buildRemoteChallenge and buildLocalChallenge to [avalanche] implement buildRemoteSighash and buildLocalSighash.Mar 19 2021, 13:17
PiRK edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B15379: Diff 27968.Mar 19 2021, 13:30
Fabien accepted this revision.Mar 19 2021, 13:44
This revision is now accepted and ready to land.Mar 19 2021, 13:44
Closed by commit rABCf07ea60dfe3a: [avalanche] implement buildRemoteSighash and buildLocalSighash (authored by PiRK). · Explain WhyMar 19 2021, 16:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf07ea60dfe3a: [avalanche] implement buildRemoteSighash and buildLocalSighash.

Revision Contents
Changeset List

PathSize
src/
avalanche/
12 lines
28 lines

Diff 27972

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...