Differential D9331

last_transaction in getpeerinfo
ClosedPublic
Actions

Authored by Fabien on Mar 18 2021, 20:01.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd923449b165b: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in…

Summary

This PR adds inbound peer eviction criteria nLastBlockTime and
nLastTXTime to CNodeStats and CNode::copyStats, which then allows
exposing them in the next commit as last_transaction and last_block Unix
Epoch Time fields in RPC getpeerinfo.

Backport of core#19731.

Depends on D9324 and D9330.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 18 2021, 20:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2021, 20:01

Fabien requested review of this revision.Mar 18 2021, 20:01

teamcity edited the summary of this revision. (Show Details)Mar 18 2021, 20:01

Fabien added a child revision: D9332: net: improve nLastBlockTime and nLastTXTime documentation.Mar 18 2021, 20:04

Harbormaster completed remote builds in B15373: Diff 27962.Mar 18 2021, 20:14

Fabien added a child revision: D9334: Add -netinfo peer connections dashboard.Mar 18 2021, 20:40

PiRK accepted this revision.Mar 19 2021, 07:23

This revision is now accepted and ready to land.Mar 19 2021, 07:23

Closed by commit rABCd923449b165b: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in… (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyMar 22 2021, 09:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd923449b165b: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in….

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

3 lines

src/

net.h

2 lines

net.cpp

2 lines

rpc/

net.cpp

9 lines

test/

functional/

rpc_net.py

56 lines

Diff 27980

View Options

doc/release-notes.md

View Options

src/net.h

View Options

src/net.cpp

View Options

src/rpc/net.cpp

View Options

test/functional/rpc_net.py

net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27980

doc/release-notes.md

src/net.h

src/net.cpp

src/rpc/net.cpp

test/functional/rpc_net.py

net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo
ClosedPublic
Actions

Revision Contents
Changeset List