Paths

Table of Contentst

Differential D9358

[Cashtab] Add fiat price value to tx history
ClosedPublic
Actions

Authored by bytesofman on Mar 29 2021, 18:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd6345e3c4b99: [Cashtab] Add fiat price value to tx history

Summary

Display USD value of BCHA transactions in transaction history

Test Plan

npm test. Can npm start and confirm appearance and css. This diff passes an existing variable to tx history and only renders the price if the inputs are valid.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 29 2021, 18:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2021, 18:33

bytesofman requested review of this revision.Mar 29 2021, 18:33

Harbormaster completed remote builds in B15425: Diff 28044.Mar 29 2021, 18:35

Fabien accepted this revision.Mar 30 2021, 08:28

This revision is now accepted and ready to land.Mar 30 2021, 08:28

Closed by commit rABCd6345e3c4b99: [Cashtab] Add fiat price value to tx history (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyMar 30 2021, 16:10

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCd6345e3c4b99: [Cashtab] Add fiat price value to tx history.

bytesofman mentioned this in D9359: [Cashtab] Add latest features to browser extension.Mar 30 2021, 16:11

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Wallet/

Tx.js

45 lines

TxHistory.js

4 lines

Wallet.js

5 lines

__tests__/

__snapshots__/

Wallet.test.js.snap

30 lines

Diff 28049

View Options

web/cashtab/src/components/Wallet/Tx.js

View Options

web/cashtab/src/components/Wallet/TxHistory.js

View Options

web/cashtab/src/components/Wallet/Wallet.js

View Options

web/cashtab/src/components/Wallet/tests/snapshots/Wallet.test.js.snap

[Cashtab] Add fiat price value to tx historyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28049

web/cashtab/src/components/Wallet/Tx.js

web/cashtab/src/components/Wallet/TxHistory.js

web/cashtab/src/components/Wallet/Wallet.js

web/cashtab/src/components/Wallet/__tests__/__snapshots__/Wallet.test.js.snap

[Cashtab] Add fiat price value to tx history
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/components/Wallet/tests/snapshots/Wallet.test.js.snap