Differential D9389

[SECP256K1] ctime_test: move context randomization test to the end
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 15:15.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC9ea4bda3ab3c: [SECP256K1] ctime_test: move context randomization test to the end

Summary

I noticed this while reviewing ElementsProject/secp256k1-zkp#117 and
finding some seemingly unnecessary VALGRIND_MAKE_MEM_DEFINED that I
couldn't remove until I saw the bug.

Backport of secp256k1#894

Test Plan

ninja check-secp256k1

libtool --mode=execute valgrind ./valgrind_ctime_test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 8 2021, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 15:15

Fabien requested review of this revision.Apr 8 2021, 15:15

teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 15:15

Harbormaster completed remote builds in B15473: Diff 28120.Apr 8 2021, 15:28

majcosta accepted this revision.Apr 8 2021, 16:10

This revision is now accepted and ready to land.Apr 8 2021, 16:10

Closed by commit rABC9ea4bda3ab3c: [SECP256K1] ctime_test: move context randomization test to the end (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by Fabien). · Explain WhyApr 8 2021, 17:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9ea4bda3ab3c: [SECP256K1] ctime_test: move context randomization test to the end.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

valgrind_ctime_test.c

62 lines

Diff 28125

View Options

src/secp256k1/src/valgrind_ctime_test.c

[SECP256K1] ctime_test: move context randomization test to the endClosedPublicActions