HomePhabricator

[SECP256K1] ctime_test: move context randomization test to the end

Description

[SECP256K1] ctime_test: move context randomization test to the end

Summary:

I noticed this while reviewing ElementsProject/secp256k1-zkp#117 and
finding some seemingly unnecessary VALGRIND_MAKE_MEM_DEFINED that I
couldn't remove until I saw the bug.

Backport of secp256k1#894

Test Plan:

ninja check-secp256k1

libtool --mode=execute valgrind ./valgrind_ctime_test

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9389

Details

Provenance
Jonas Nick <jonasd.nick@gmail.com>Authored on Feb 4 2021, 23:17
FabienCommitted on Apr 8 2021, 17:21
FabienPushed on Apr 8 2021, 17:24
Reviewer
Restricted Project
Differential Revision
D9389: [SECP256K1] ctime_test: move context randomization test to the end
Parents
rABCcda247c5f7da: [SECP256K1] Use bit ops instead of int mult for constant-time logic in…
Branches
Unknown
Tags
Unknown