Differential D9403

[SECP256K1] Improve bounds checks in modinv modules
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:24.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC76ecd0d3ed0e: [SECP256K1] Improve bounds checks in modinv modules

Summary

This commit adds functions to verify and compare numbers in
signed{30,62} notation, and uses that to do more extensive bounds
checking on various variables in the modinv code.

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/08d54964e51f318ef0cc4ef09d64cfa5ec143c5c

Depends on D9402.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 13 2021, 18:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:24

Fabien requested review of this revision.Apr 13 2021, 18:25

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:25

Fabien added a child revision: D9404: [SECP256K1] Move secp256k1_scalar_{inverse{_var},is_even} and secp256k1_fe_inverse{_var} to per-impl files.Apr 13 2021, 18:26

Harbormaster completed remote builds in B15498: Diff 28156.Apr 13 2021, 18:57

majcosta accepted this revision.Apr 13 2021, 21:23

This revision is now accepted and ready to land.Apr 13 2021, 21:23

Closed by commit rABC76ecd0d3ed0e: [SECP256K1] Improve bounds checks in modinv modules (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyApr 14 2021, 06:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC76ecd0d3ed0e: [SECP256K1] Improve bounds checks in modinv modules.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

modinv32_impl.h

143 lines

modinv64_impl.h

147 lines

Diff 28170

View Options

src/secp256k1/src/modinv32_impl.h