Page MenuHomePhabricator

[SECP256K1] Remove num/gmp support
ClosedPublic

Authored by Fabien on Tue, Apr 13, 18:31.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC6c967a512a3e: [SECP256K1] Remove num/gmp support
Summary
The whole "num" API and its libgmp-based implementation are now unused.
Remove them.

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c

Depends on D9407.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Tue, Apr 13, 18:31
This revision now requires changes to proceed.Tue, Apr 13, 23:32
Fabien requested review of this revision.Wed, Apr 14, 06:32
Fabien edited the summary of this revision. (Show Details)

Updated the summary with the correct commit link.

https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd is indeed a skip, since the removed function is still used for our Schnorr implementation.

This revision is now accepted and ready to land.Wed, Apr 14, 07:51
This revision was automatically updated to reflect the committed changes.