The whole "num" API and its libgmp-based implementation are now unused. Remove them.
Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c
Depends on D9407.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABC6c967a512a3e: [SECP256K1] Remove num/gmp support
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
is https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd a skip? it's linked in the summary but this is a diff for: https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c
| src/secp256k1/src/bench_internal.c | ||
|---|---|---|
| 249–268 ↗ | (On Diff #28161) | |
Comment Actions
Updated the summary with the correct commit link.
https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd is indeed a skip, since the removed function is still used for our Schnorr implementation.