Differential D9408

[SECP256K1] Remove num/gmp support
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:31.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6c967a512a3e: [SECP256K1] Remove num/gmp support

Summary

The whole "num" API and its libgmp-based implementation are now unused.
Remove them.

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c

Depends on D9407.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR831_p8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15503
Build 30926: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-diff · build-debug · build-clang-tidy · build-clang
Build 30925: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2021, 18:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:31

Fabien requested review of this revision.Apr 13 2021, 18:31

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:31

Fabien added a child revision: D9409: [SECP256K1] Optimization: special-case zero modulus limbs in modinv64.Apr 13 2021, 18:32

Harbormaster completed remote builds in B15503: Diff 28161.Apr 13 2021, 19:36

is https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd a skip? it's linked in the summary but this is a diff for: https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c

This revision now requires changes to proceed.Apr 13 2021, 23:32

majcosta added inline comments.Apr 13 2021, 23:53

src/secp256k1/src/bench_internal.c
249–268	this is removed in https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd

Updated the summary with the correct commit link.

https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd is indeed a skip, since the removed function is still used for our Schnorr implementation.

got it

This revision is now accepted and ready to land.Apr 14 2021, 07:51

Closed by commit rABC6c967a512a3e: [SECP256K1] Remove num/gmp support (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyApr 14 2021, 09:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6c967a512a3e: [SECP256K1] Remove num/gmp support.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

src/

secp256k1/

16 lines

14 lines

4 lines

build-aux/

m4/

bitcoin_secp.m4

13 lines

ci/

build_autotools.sh

1 line

1 line

linux-debian.Dockerfile

4 lines

58 lines

src/

9 lines

1 line

bench_internal.c

22 lines

1 line

21 lines

1 line

1 line

libsecp256k1-config.h.cmake.in

8 lines

9 lines

28 lines

1 line

326 lines

Diff 28161

cmake/modules/FindGMP.cmake

Loading...

src/secp256k1/.cirrus.yml

Loading...

src/secp256k1/CMakeLists.txt

Loading...

src/secp256k1/Makefile.am

Loading...

src/secp256k1/build-aux/m4/bitcoin_secp.m4

Loading...

src/secp256k1/ci/build_autotools.sh

Loading...

src/secp256k1/ci/build_cmake.sh

Loading...

src/secp256k1/ci/linux-debian.Dockerfile

Loading...

src/secp256k1/configure.ac

Loading...

src/secp256k1/src/basic-config.h

Loading...

src/secp256k1/src/bench_ecmult.c

Loading...

src/secp256k1/src/bench_internal.c

Loading...

src/secp256k1/src/ecmult.h

Loading...

src/secp256k1/src/field_impl.h

Loading...

src/secp256k1/src/group.h

Loading...

src/secp256k1/src/group_impl.h

Loading...

src/secp256k1/src/libsecp256k1-config.h.cmake.in

Loading...

src/secp256k1/src/num.h

Loading...

src/secp256k1/src/num_gmp.h

Loading...

src/secp256k1/src/num_gmp_impl.h

Loading...

src/secp256k1/src/num_impl.h

Loading...

src/secp256k1/src/scalar.h

Loading...

src/secp256k1/src/scalar_impl.h

Loading...

src/secp256k1/src/secp256k1.c

Loading...

src/secp256k1/src/tests.c

Loading...