Page MenuHomePhabricator

Add test for CWalletTx::GetImmatureCredit() returning stale values.
ClosedPublic

Authored by deadalnix on Jan 12 2018, 23:48.

Details

Summary

Add test for cached immature credit flag not being cleared in
CWalletTx::MarkDirty() bug, which was fixed in
https://github.com/bitcoin/bitcoin/pull/8717, commit a560378.

Bacport of core's PR9359

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletimmaturecredittest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1590
Build 1590: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
535

Should 50 * COIN be wrapped in Amount() like the Amount(0) is?

src/wallet/test/wallet_tests.cpp
535

No, COIN is an Amount .

This revision is now accepted and ready to land.Jan 13 2018, 00:58
This revision was automatically updated to reflect the committed changes.