Page MenuHomePhabricator
Differential D943

Factor out CWallet::nTimeSmart computation into a method.
ClosedPublic
Actions

Authored by deadalnix on Jan 13 2018, 00:24.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING3a1ad4367fb7: Factor out CWallet::nTimeSmart computation into a method.
rABC3a1ad4367fb7: Factor out CWallet::nTimeSmart computation into a method.
Summary

No change in behavior, this change just pulls some code out of
CWallet::AddToWallet that was making it very long into a separate method.

Backport of core's PR9369

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 13 2018, 00:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2018, 00:24
Harbormaster completed remote builds in B1592: Diff 2476.Jan 13 2018, 00:24
deadalnix added a child revision: D945: Fix importwallet edge case rescan bug.Jan 13 2018, 02:07
schancel accepted this revision.Jan 14 2018, 00:57
schancel added inline comments.
src/wallet/wallet.cpp
3902 ↗(On Diff #2476)

Any idea why this was done?

3925 ↗(On Diff #2476)

:grumble:

This revision is now accepted and ready to land.Jan 14 2018, 00:57
deadalnix added inline comments.Jan 14 2018, 01:02
src/wallet/wallet.cpp
1018 ↗(On Diff #2476)

See original code here.

3902 ↗(On Diff #2476)

Not sure, but the code was moved.

deadalnix added inline comments.Jan 14 2018, 01:04
src/wallet/wallet.cpp
3902 ↗(On Diff #2476)

My bet is on ensuring you do not mutate things by mistake.

deadalnix updated this revision to Diff 2484.Jan 14 2018, 01:05

restore a legit use of nullptr

Harbormaster completed remote builds in B1595: Diff 2484.Jan 14 2018, 01:05
Closed by commit rABC3a1ad4367fb7: Factor out CWallet::nTimeSmart computation into a method. (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyJan 14 2018, 01:05
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
52 lines
10 lines
118 lines

Diff 2485

View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...