Page MenuHomePhabricator

Introduce constant for mempool-based relay separate from mapRelay caching
ClosedPublic

Authored by PiRK on Tue, Apr 20, 16:07.

Details

Summary

This constant is set to 2 minutes, rather than 15. This is still many times
larger than the transaction broadcast interval (2s for outbound, 5s for
inbound), so it should be acceptable for peers to know what our contents of
the mempool was that long ago.

This is a partial backport of core#19109 [2/5]
https://github.com/bitcoin/bitcoin/pull/19109/commits/b24a17f03982c9cd8fd6ec665b16e022374c96f0

Depends on D9434

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Apr 20, 16:07

Tail of the build log:

[393/449] Running utility command for check-bitcoin-txvalidationcache_tests
[394/449] Running utility command for check-bitcoin-dnsseeds_tests
[395/449] bitcoin: testing sync_tests
[396/449] Running utility command for check-bitcoin-sync_tests
[397/449] bitcoin: testing torcontrol_tests
[398/449] Running utility command for check-bitcoin-torcontrol_tests
[399/449] bitcoin: testing settings_tests
[400/449] Running utility command for check-bitcoin-settings_tests
[401/449] bitcoin: testing timedata_tests
[402/449] bitcoin: testing wallet_tests
[403/449] Running utility command for check-bitcoin-timedata_tests
[404/449] bitcoin: testing streams_tests
[405/449] Running utility command for check-bitcoin-wallet_tests
[406/449] Running utility command for check-bitcoin-streams_tests
[407/449] bitcoin: testing serialize_tests
[408/449] Running utility command for check-bitcoin-serialize_tests
[409/449] bitcoin: testing blockcheck_tests
[410/449] bitcoin: testing scriptpubkeyman_tests
[411/449] Running utility command for check-bitcoin-blockcheck_tests
[412/449] bitcoin: testing schnorr_tests
[413/449] Running utility command for check-bitcoin-scriptpubkeyman_tests
[414/449] bitcoin: testing validation_flush_tests
[415/449] Running utility command for check-bitcoin-schnorr_tests
[416/449] bitcoin: testing radix_tests
[417/449] Running utility command for check-bitcoin-validation_flush_tests
[418/449] bitcoin: testing op_reversebytes_tests
[419/449] Running utility command for check-bitcoin-radix_tests
[420/449] bitcoin: testing compilerbug_tests
[421/449] Running utility command for check-bitcoin-op_reversebytes_tests
[422/449] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,message:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Segmentation fault (core dumped)
[423/449] Running utility command for check-bitcoin-compilerbug_tests
[424/449] bitcoin: testing checkpoints_tests
[425/449] bitcoin: testing blockstatus_tests
[426/449] Running utility command for check-bitcoin-checkpoints_tests
[427/449] bitcoin: testing cashaddr_tests
[428/449] Running utility command for check-bitcoin-blockstatus_tests
[429/449] bitcoin: testing validationinterface_tests
[430/449] Running utility command for check-bitcoin-cashaddr_tests
[431/449] Running utility command for check-bitcoin-validationinterface_tests
[432/449] bitcoin: testing script_tests
[433/449] Running utility command for check-bitcoin-script_tests
[434/449] bitcoin: testing crypto_tests
[435/449] bitcoin: testing versionbits_tests
[436/449] Running utility command for check-bitcoin-crypto_tests
[437/449] Running utility command for check-bitcoin-versionbits_tests
[438/449] bitcoin: testing util_tests
[439/449] Running utility command for check-bitcoin-util_tests
[440/449] bitcoin: testing monolith_opcodes_tests
[441/449] Running utility command for check-bitcoin-monolith_opcodes_tests
[442/449] bitcoin: testing transaction_tests
[443/449] bitcoin: testing skiplist_tests
[444/449] Running utility command for check-bitcoin-transaction_tests
[445/449] Running utility command for check-bitcoin-skiplist_tests
[446/449] bitcoin: testing coins_tests
[447/449] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
majcosta added a subscriber: majcosta.

built and tested locally ok

This revision is now accepted and ready to land.Tue, Apr 20, 17:05
This revision was landed with ongoing or failed builds.Wed, Apr 21, 06:32
This revision was automatically updated to reflect the committed changes.