Page MenuHomePhabricator

remove misleading comment
ClosedPublic

Authored by PiRK on May 7 2021, 10:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1477b37ad2cc: remove misleading comment
Summary

-enableavalanche does not imply that the service flag is set (since D9422).
The code is simple enough to not require a comment.

Test Plan

NA

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.May 7 2021, 10:05
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
2744 ↗(On Diff #28378)

This whole block doesn't make sense. How are you supposed to get an avaresponse if you have not polled? All that this achieve is preventing detection of peer sending invalid response during IBD. How is that an improvement?

About poll, why ignore and leave the peer hanging? Why not just answer that you don't know for every item requested? In fact, this is already what is happening with blocks, and that is the only thing we poll for today.

I know you didn't introduce this, but this keeps being modified and the problem remains.

This revision is now accepted and ready to land.May 7 2021, 13:17
This revision was automatically updated to reflect the committed changes.
This comment was removed by Mengerian.