Page MenuHomePhabricator
Differential D9482

remove misleading comment
ClosedPublic
Actions

Authored by PiRK on May 7 2021, 10:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1477b37ad2cc: remove misleading comment
Summary

-enableavalanche does not imply that the service flag is set (since D9422).
The code is simple enough to not require a comment.

Test Plan

NA

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 7 2021, 10:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2021, 10:05
PiRK requested review of this revision.May 7 2021, 10:05
Harbormaster completed remote builds in B15653: Diff 28378.May 7 2021, 10:22
deadalnix accepted this revision.May 7 2021, 13:17
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
2744 ↗(On Diff #28378)

This whole block doesn't make sense. How are you supposed to get an avaresponse if you have not polled? All that this achieve is preventing detection of peer sending invalid response during IBD. How is that an improvement?

About poll, why ignore and leave the peer hanging? Why not just answer that you don't know for every item requested? In fact, this is already what is happening with blocks, and that is the only thing we poll for today.

I know you didn't introduce this, but this keeps being modified and the problem remains.

This revision is now accepted and ready to land.May 7 2021, 13:17
Closed by commit rABC1477b37ad2cc: remove misleading comment (authored by PiRK). · Explain WhyMay 10 2021, 14:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1477b37ad2cc: remove misleading comment.
PiRK mentioned this in D9494: [avalanche] don't ignore avapoll and avaresponse while importing.May 10 2021, 15:55
PiRK mentioned this in rABCc7ab326c7f80: [avalanche] don't ignore avapoll and avaresponse while importing.May 12 2021, 11:34
• Mann123 added a subscriber: • Mann123.May 18 2021, 06:59
This comment was removed by Mengerian.
Mengerian added a subscriber: Mengerian.May 18 2021, 16:31

Revision Contents
Changeset List

PathSize
src/
1 line

Diff 28403

View Options

src/net_processing.cpp

Loading...