Page MenuHomePhabricator
Differential D9490

Factorize flushing the inventory buffer when it reaches its max size
ClosedPublic
Actions

Authored by Fabien on May 10 2021, 08:44.

Details

Reviewers
PiRK
deadalnix
Group Reviewers
Restricted Project
Commits
rABC38b2d48064b4: Factorize flushing the inventory buffer when it reaches its max size
Summary

The code is duplicated and more will be needed for D9489.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 10 2021, 08:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2021, 08:44
Fabien requested review of this revision.May 10 2021, 08:44
Harbormaster completed remote builds in B15667: Diff 28399.May 10 2021, 08:59
Fabien mentioned this in D9489: [avalanche] Annouce our proofs to our peers.May 10 2021, 09:18
PiRK accepted this revision.May 10 2021, 14:12
This revision is now accepted and ready to land.May 10 2021, 14:12
deadalnix requested changes to this revision.May 10 2021, 14:51
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
5196 ↗(On Diff #28399)

You need to move this. Why would you copy all the content, just so that you can clear it immediately after?

5339 ↗(On Diff #28399)

Put it there. This is where the rest of the code related to sending inv is (such as the number of transaction relayed).

This revision now requires changes to proceed.May 10 2021, 14:51
Fabien updated this revision to Diff 28407.May 10 2021, 15:03

Address feedback

src/net_processing.cpp
5196 ↗(On Diff #28399)

I would have expected the clear() to trigger a use after move warning, TIL

Harbormaster completed remote builds in B15674: Diff 28407.May 10 2021, 15:19
deadalnix accepted this revision.May 10 2021, 15:36
This revision is now accepted and ready to land.May 10 2021, 15:36
Closed by commit rABC38b2d48064b4: Factorize flushing the inventory buffer when it reaches its max size (authored by Fabien). · Explain WhyMay 11 2021, 07:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC38b2d48064b4: Factorize flushing the inventory buffer when it reaches its max size.

Revision Contents
Changeset List

PathSize
src/
31 lines

Diff 28412

View Options

src/net_processing.cpp

Loading...