Differential D9508

p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 14:15.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC25996e7e2388: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing

Summary

and otherwise log that an unknown INV type was received.

In INV processing, when handling transaction type inv messages,
ToGenTxid() expects that we constructed the CInv ourselves or
that we verified that it is for a transaction type CInv.

Therefore, change this `else` branch into an `else if (inv.GenMsgTx())`
to make this safer and log any INVs that fall through.

Completes backport of core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/fb56d37612dea6666e7da73d671311a697570dae

Depends on D9507.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 12 2021, 14:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 14:15

Fabien requested review of this revision.May 12 2021, 14:16

teamcity edited the summary of this revision. (Show Details)May 12 2021, 14:16

Harbormaster completed remote builds in B15695: Diff 28434.May 12 2021, 14:26

majcosta accepted this revision.May 12 2021, 14:49

This revision is now accepted and ready to land.May 12 2021, 14:49

Closed by commit rABC25996e7e2388: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC25996e7e2388: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

6 lines

Diff 28450

src/net_processing.cpp

Loading...